tenders-finder/src/components/ui/chart.tsx-249-268 (1)

249-268: ⚠️ Potential issue | 🟡 Minor

Use stable, unique keys for legend entries.
key={item.value} can collide or be undefined.

✅ Suggested fix

-      {payload.map((item) => {
+      {payload.map((item, index) => {
         const key = `${nameKey || item.dataKey || "value"}`;
         const itemConfig = getPayloadConfigFromPayload(config, item, key);
 
         return (
           <div
-            key={item.value}
+            key={`${item.dataKey ?? item.value ?? "legend"}-${index}`}
             className={cn("flex items-center gap-1.5 [&>svg]:h-3 [&>svg]:w-3 [&>svg]:text-muted-foreground")}
           >
             {itemConfig?.icon && !hideIcon ? (
               <itemConfig.icon />
             ) : (
               <div
                 className="h-2 w-2 shrink-0 rounded-[2px]"
                 style={{
                   backgroundColor: item.color,
                 }}
               />
             )}
             {itemConfig?.label}
           </div>
         );
       })}

tenders-finder/src/components/ui/chart.tsx-163-214 (1)

163-214: ⚠️ Potential issue | 🟡 Minor

Render zero values and use stable list keys.
item.value && skips 0, and key={item.dataKey} can be undefined or duplicate.

✅ Suggested fixes

-          {payload.map((item, index) => {
+          {payload.map((item, index) => {
             const key = `${nameKey || item.name || item.dataKey || "value"}`;
             const itemConfig = getPayloadConfigFromPayload(config, item, key);
             const indicatorColor = color || item.payload.fill || item.color;
 
             return (
               <div
-                key={item.dataKey}
+                key={`${item.dataKey ?? key}-${index}`}
                 className={cn(
                   "flex w-full flex-wrap items-stretch gap-2 [&>svg]:h-2.5 [&>svg]:w-2.5 [&>svg]:text-muted-foreground",
                   indicator === "dot" && "items-center",
                 )}
               >
                 {formatter && item?.value !== undefined && item.name ? (
                   formatter(item.value, item.name, item, index, item.payload)
                 ) : (
                   <>
                     {itemConfig?.icon ? (
                       <itemConfig.icon />
                     ) : (
                       !hideIndicator && (
                         <div
                           className={cn("shrink-0 rounded-[2px] border-[--color-border] bg-[--color-bg]", {
                             "h-2.5 w-2.5": indicator === "dot",
                             "w-1": indicator === "line",
                             "w-0 border-[1.5px] border-dashed bg-transparent": indicator === "dashed",
                             "my-0.5": nestLabel && indicator === "dashed",
                           })}
                           style={
                             {
                               "--color-bg": indicatorColor,
                               "--color-border": indicatorColor,
                             } as React.CSSProperties
                           }
                         />
                       )
                     )}
                     <div
                       className={cn(
                         "flex flex-1 justify-between leading-none",
                         nestLabel ? "items-end" : "items-center",
                       )}
                     >
                       <div className="grid gap-1.5">
                         {nestLabel ? tooltipLabel : null}
                         <span className="text-muted-foreground">{itemConfig?.label || item.name}</span>
                       </div>
-                      {item.value && (
+                      {item.value !== undefined && item.value !== null && (
                         <span className="font-mono font-medium tabular-nums text-foreground">
                           {item.value.toLocaleString()}
                         </span>
                       )}
                     </div>
                   </>
                 )}
               </div>
             );
           })}

tenders-finder/src/components/ui/sidebar.tsx-22-30 (1)

22-30: ⚠️ Potential issue | 🟡 Minor

Type mismatch for setOpen signature.

The setOpen type on line 25 declares (open: boolean) => void, but the actual implementation (lines 58-71) accepts boolean | ((value: boolean) => boolean) to support the function updater pattern. This inconsistency could cause TypeScript errors if consumers attempt to use the updater pattern.

🔧 Proposed fix

 type SidebarContext = {
   state: "expanded" | "collapsed";
   open: boolean;
-  setOpen: (open: boolean) => void;
+  setOpen: (open: boolean | ((value: boolean) => boolean)) => void;
   openMobile: boolean;
   setOpenMobile: (open: boolean) => void;
   isMobile: boolean;
   toggleSidebar: () => void;
 };

tenders-finder/src/components/ui/sidebar.tsx-363-366 (1)

363-366: ⚠️ Potential issue | 🟡 Minor

Truncated CSS transition property.

Line 364 has transition-[margin,opa] which appears truncated. It should be transition-[margin,opacity] for the opacity transition to work correctly during collapse animations.

🐛 Proposed fix

         className={cn(
-          "flex h-8 shrink-0 items-center rounded-md px-2 text-xs font-medium text-sidebar-foreground/70 outline-none ring-sidebar-ring transition-[margin,opa] duration-200 ease-linear focus-visible:ring-2 [&>svg]:size-4 [&>svg]:shrink-0",
+          "flex h-8 shrink-0 items-center rounded-md px-2 text-xs font-medium text-sidebar-foreground/70 outline-none ring-sidebar-ring transition-[margin,opacity] duration-200 ease-linear focus-visible:ring-2 [&>svg]:size-4 [&>svg]:shrink-0",
           "group-data-[collapsible=icon]:-mt-8 group-data-[collapsible=icon]:opacity-0",
           className,
         )}

tenders-finder/src/components/ui/sidebar.tsx-534-537 (1)

534-537: ⚠️ Potential issue | 🟡 Minor

Potential SSR hydration mismatch with Math.random().

Using Math.random() inside useMemo with an empty dependency array causes hydration mismatches in SSR/SSG scenarios. The server generates one random value, while the client generates a different one, leading to React hydration warnings or visual flicker.

🔧 Proposed fix using useId or state initialization

+import { useId } from "react";
+
 const SidebarMenuSkeleton = React.forwardRef<
   HTMLDivElement,
   React.ComponentProps<"div"> & {
     showIcon?: boolean;
   }
 >(({ className, showIcon = false, ...props }, ref) => {
-  // Random width between 50 to 90%.
-  const width = React.useMemo(() => {
-    return `${Math.floor(Math.random() * 40) + 50}%`;
-  }, []);
+  // Generate consistent width using useId hash
+  const id = React.useId();
+  const width = React.useMemo(() => {
+    // Simple hash from id to get deterministic value between 50-90%
+    const hash = id.split('').reduce((acc, char) => acc + char.charCodeAt(0), 0);
+    return `${(hash % 40) + 50}%`;
+  }, [id]);

Alternatively, if the random appearance is essential and this component won't be SSR'd, you can initialize the width in a useEffect with useState:

 const SidebarMenuSkeleton = React.forwardRef<
   HTMLDivElement,
   React.ComponentProps<"div"> & {
     showIcon?: boolean;
   }
 >(({ className, showIcon = false, ...props }, ref) => {
-  // Random width between 50 to 90%.
-  const width = React.useMemo(() => {
-    return `${Math.floor(Math.random() * 40) + 50}%`;
-  }, []);
+  // Random width between 50 to 90%, initialized client-side only.
+  const [width, setWidth] = React.useState("70%");
+  React.useEffect(() => {
+    setWidth(`${Math.floor(Math.random() * 40) + 50}%`);
+  }, []);

tenders-finder/src/components/ui/button.tsx-39-43 (1)

39-43: ⚠️ Potential issue | 🟡 Minor

Default type="button" when rendering a native button.
Buttons without an explicit type default to type="submit" per the HTML spec, causing unintended form submissions when used inside forms. Extract the type prop and default to "button" for native buttons.

🛠️ Proposed fix

const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
-  ({ className, variant, size, asChild = false, ...props }, ref) => {
+  ({ className, variant, size, asChild = false, type, ...props }, ref) => {
     const Comp = asChild ? Slot : "button";
-    return <Comp className={cn(buttonVariants({ variant, size, className }))} ref={ref} {...props} />;
+    return (
+      <Comp
+        type={asChild ? undefined : type ?? "button"}
+        className={cn(buttonVariants({ variant, size, className }))}
+        ref={ref}
+        {...props}
+      />
+    );
   },
 );

tenders-finder/src/components/ui/hover-card.tsx-13-23 (1)

13-23: ⚠️ Potential issue | 🟡 Minor

Wrap HoverCardContent in a Portal to prevent overflow clipping and match codebase patterns.

All other overlay components in this codebase (Popover, DropdownMenu, ContextMenu, Select, Dialog, etc.) use Portal wrappers for their content. This aligns with Radix's documented approach for preventing content from being clipped by parent overflow: hidden contexts.

Proposed fix

>(({ className, align = "center", sideOffset = 4, ...props }, ref) => (
+  <HoverCardPrimitive.Portal>
    <HoverCardPrimitive.Content
      ref={ref}
      align={align}
      sideOffset={sideOffset}
      className={cn(
        "z-50 w-64 rounded-md border bg-popover p-4 text-popover-foreground shadow-md outline-none data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[side=bottom]:slide-in-from-top-2 data-[side=left]:slide-in-from-right-2 data-[side=right]:slide-in-from-left-2 data-[side=top]:slide-in-from-bottom-2",
        className,
      )}
      {...props}
    />
+  </HoverCardPrimitive.Portal>
));

tenders-finder/src/components/ui/card.tsx-17-22 (1)

17-22: ⚠️ Potential issue | 🟡 Minor

Fix ref element type mismatch for CardTitle.

CardTitle renders an h3 element but the ref generic is typed as HTMLParagraphElement. This should be HTMLHeadingElement to match the actual rendered element and ensure correct type safety.

🛠️ Proposed fix

-const CardTitle = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLHeadingElement>>(
+const CardTitle = React.forwardRef<HTMLHeadingElement, React.HTMLAttributes<HTMLHeadingElement>>(

tenders-finder/supabase/functions/mino-tender-search/index.ts-169-171 (1)

169-171: ⚠️ Potential issue | 🟡 Minor

Silent error swallowing may hide parsing issues.

Catching and ignoring JSON parsing errors without any indication could make debugging difficult when the Mino API returns unexpected data formats.

Suggested improvement

                   } catch (e) {
-                    // Ignore parsing errors
+                    // Log parsing errors for debugging but continue processing
+                    console.warn(`[${agentId}] Failed to parse SSE data:`, line.slice(6));
                   }

tenders-finder/src/components/ui/alert.tsx-29-34 (1)

29-34: ⚠️ Potential issue | 🟡 Minor

Ref type mismatch: renders <h5> but typed as HTMLParagraphElement.

The component renders an <h5> element but the ref is typed as HTMLParagraphElement. This should be HTMLHeadingElement for type correctness.

Suggested fix

-const AlertTitle = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLHeadingElement>>(
+const AlertTitle = React.forwardRef<HTMLHeadingElement, React.HTMLAttributes<HTMLHeadingElement>>(

tenders-finder/src/components/tender/CompareModal.tsx-90-103 (1)

90-103: ⚠️ Potential issue | 🟡 Minor

Dead code: officialTenderUrl field check will never match.

The condition field.key === 'officialTenderUrl' will never be true because officialTenderUrl is not included in the COMPARE_FIELDS array. This special-case rendering is unreachable. The official URL is already handled correctly in the dedicated row at lines 108-128.

Suggested fix - simplify the cell rendering

                         {tenders.map((tender) => (
                           <td
                             key={`${tender.id}-${field.key}`}
                             className="p-3 text-foreground border border-border"
                           >
-                            {field.key === 'officialTenderUrl' ? (
-                              <a
-                                href={tender[field.key]}
-                                target="_blank"
-                                rel="noopener noreferrer"
-                                className="text-primary hover:underline inline-flex items-center gap-1"
-                              >
-                                View <ExternalLink className="w-3 h-3" />
-                              </a>
-                            ) : (
-                              <span className="line-clamp-3">
-                                {tender[field.key] || 'N/A'}
-                              </span>
-                            )}
+                            <span className="line-clamp-3">
+                              {tender[field.key] || 'N/A'}
+                            </span>
                           </td>
                         ))}

tenders-finder/src/components/ui/alert.tsx-36-41 (1)

36-41: ⚠️ Potential issue | 🟡 Minor

Ref type mismatch: renders <div> but typed as HTMLParagraphElement.

The component renders a <div> element but the ref is typed as HTMLParagraphElement. This should be HTMLDivElement for type correctness.

Suggested fix

-const AlertDescription = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLParagraphElement>>(
+const AlertDescription = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTMLDivElement>>(

tenders-finder/src/components/tender/CompareModal.tsx-27-31 (1)

27-31: ⚠️ Potential issue | 🟡 Minor

Exit animations won't trigger due to early return.

The early return null on line 28 prevents AnimatePresence from detecting the exit and running the exit animations defined on the motion elements. When isOpen becomes false, the component immediately returns null without giving AnimatePresence a chance to animate out.

Suggested fix

 export function CompareModal({ isOpen, onClose, tenders }: CompareModalProps) {
-  if (!isOpen) return null;
-
   return (
     <AnimatePresence>
-      <motion.div
+      {isOpen && (
+        <motion.div
           initial={{ opacity: 0 }}
           animate={{ opacity: 1 }}
           exit={{ opacity: 0 }}
           // ... rest of component
-      </motion.div>
+        </motion.div>
+      )}
     </AnimatePresence>
   );
 }

tenders-finder/src/components/ui/breadcrumb.tsx-69-80 (1)

69-80: ⚠️ Potential issue | 🟡 Minor

Fix displayName typo for BreadcrumbEllipsis

The displayName string is misspelled, which makes DevTools inspection harder.

🛠️ Suggested fix

-BreadcrumbEllipsis.displayName = "BreadcrumbElipssis";
+BreadcrumbEllipsis.displayName = "BreadcrumbEllipsis";

tenders-finder/src/components/ui/carousel.tsx-70-81 (1)

70-81: ⚠️ Potential issue | 🟡 Minor

Handle arrow keys for vertical orientation

ArrowUp/ArrowDown should control vertical carousels; current logic only reacts to left/right.

🛠️ Suggested update

-    const handleKeyDown = React.useCallback(
-      (event: React.KeyboardEvent<HTMLDivElement>) => {
-        if (event.key === "ArrowLeft") {
-          event.preventDefault();
-          scrollPrev();
-        } else if (event.key === "ArrowRight") {
-          event.preventDefault();
-          scrollNext();
-        }
-      },
-      [scrollPrev, scrollNext],
-    );
+    const handleKeyDown = React.useCallback(
+      (event: React.KeyboardEvent<HTMLDivElement>) => {
+        const isHorizontal = orientation === "horizontal";
+        if (
+          (isHorizontal && event.key === "ArrowLeft") ||
+          (!isHorizontal && event.key === "ArrowUp")
+        ) {
+          event.preventDefault();
+          scrollPrev();
+        } else if (
+          (isHorizontal && event.key === "ArrowRight") ||
+          (!isHorizontal && event.key === "ArrowDown")
+        ) {
+          event.preventDefault();
+          scrollNext();
+        }
+      },
+      [orientation, scrollPrev, scrollNext],
+    );

tenders-finder/src/components/ui/command.tsx-70-74 (1)

70-74: ⚠️ Potential issue | 🟡 Minor

Preserve base styles in CommandEmpty

Props are spread after className, so consumer className can wipe default styles. Merge with cn.

🛠️ Suggested fix

-const CommandEmpty = React.forwardRef<
-  React.ElementRef<typeof CommandPrimitive.Empty>,
-  React.ComponentPropsWithoutRef<typeof CommandPrimitive.Empty>
->((props, ref) => <CommandPrimitive.Empty ref={ref} className="py-6 text-center text-sm" {...props} />);
+const CommandEmpty = React.forwardRef<
+  React.ElementRef<typeof CommandPrimitive.Empty>,
+  React.ComponentPropsWithoutRef<typeof CommandPrimitive.Empty>
+>(({ className, ...props }, ref) => (
+  <CommandPrimitive.Empty
+    ref={ref}
+    className={cn("py-6 text-center text-sm", className)}
+    {...props}
+  />
+));

tenders-finder/src/components/ui/carousel.tsx-91-102 (1)

91-102: ⚠️ Potential issue | 🟡 Minor

Remove both event listener registrations on cleanup

The effect registers both reInit and select listeners, but cleanup only removes select. According to Embla's API, listeners persist after reInit() and must be explicitly removed or they'll accumulate on subsequent effect runs.

Suggested fix

      return () => {
        api?.off("select", onSelect);
+       api?.off("reInit", onSelect);
      };

Note: This same pattern appears in anime-watch-hub/components/ui/carousel.tsx and summer-school-finder/src/components/ui/carousel.tsx.

tenders-finder/src/hooks/useTenderSearch.ts-95-107 (1)

95-107: ⚠️ Potential issue | 🟡 Minor

Explicitly handle null response body to avoid agent getting stuck in "connecting" state

If response.body is null (which can occur even with response.ok === true in certain HTTP scenarios), the entire streaming processing block is skipped and the agent never leaves the "connecting" status. This should be treated as an error condition.

🛠️ Suggested handling

-        const reader = response.body?.getReader();
-        const decoder = new TextDecoder();
-        let buffer = '';
-
-        if (reader) {
-          while (true) {
+        const reader = response.body?.getReader();
+        if (!reader) {
+          throw new Error('Streaming response body is unavailable');
+        }
+        const decoder = new TextDecoder();
+        let buffer = '';
+
+        while (true) {
           const { done, value } = await reader.read();
           if (done) break;
@@
-          }
-        }
+        }

The error will be caught by the existing error handler at line 216 and properly set the agent status to 'error'.

tenders-finder/index.html-6-19 (1)

6-19: ⚠️ Potential issue | 🟡 Minor

Replace placeholder metadata before release.

Line 6-19 still contain TODOs and placeholder branding (title, description, OG/Twitter meta, and image). These should be updated to the actual app name and assets to avoid incorrect previews/SEO.

tenders-finder/src/components/ui/menubar.tsx-185-189 (1)

185-189: ⚠️ Potential issue | 🟡 Minor

Fix displayName casing for MenubarShortcut.

Line 188 uses displayname (lowercase n), but React expects displayName. All other components in this file correctly use displayName.

🛠️ Suggested fix

-MenubarShortcut.displayname = "MenubarShortcut";
+MenubarShortcut.displayName = "MenubarShortcut";

tenders-finder/README.md-1-39 (1)

1-39: ⚠️ Potential issue | 🟡 Minor

Resolve markdownlint warnings (duplicate heading, bare URLs, bold-as-heading).
Consider converting bold section labels to headings and using Markdown links for URLs to clear MD034/MD024/MD036.

✅ Example formatting fixes

-**Live Link**: https://tender-scout-singapore.lovable.app
+## Live Link
+[Tender Scout Singapore](https://tender-scout-singapore.lovable.app)

-## What This Project Is -
+## What This Project Is

-**AI-based Link Discovery**
+### AI-based Link Discovery

Also applies to: 84-89

tenders-finder/README.md-6-27 (1)

6-27: ⚠️ Potential issue | 🟡 Minor

Fix the project description — it describes summer schools, not tenders.
This section should describe the Government Tender Finder for Singapore rather than a summer school tool.

✏️ Example edit

-This project is an AI-powered summer school discovery and comparison tool that automatically finds, scans, and extracts information from official summer school websites worldwide.
+This project is an AI-powered government tender discovery and comparison tool that finds, scans, and extracts tenders from official Singapore procurement portals.

tenders-finder/src/components/tender/AgentPreviewGrid.tsx-22-31 (1)

22-31: ⚠️ Potential issue | 🟡 Minor

Sorting bug: priority 0 gets overwritten by ||.
Use ?? so "searching" stays at the highest priority.

✅ Fix priority fallback

-    return (priority[a.status] || 5) - (priority[b.status] || 5);
+    return (priority[a.status] ?? 5) - (priority[b.status] ?? 5);

tenders-finder/src/hooks/use-toast.ts-140-144 (1)

140-144: ⚠️ Potential issue | 🟡 Minor

Type mismatch in update function signature.

The update function accepts ToasterToast but should accept Partial<ToasterToast> to match the UPDATE_TOAST action type defined on lines 37-39:

🐛 Proposed fix

-  const update = (props: ToasterToast) =>
+  const update = (props: Partial<ToasterToast>) =>
     dispatch({
       type: "UPDATE_TOAST",
       toast: { ...props, id },
     });

tenders-finder/src/components/tender/AgentPreviewCard.tsx-210-215 (1)

210-215: ⚠️ Potential issue | 🟡 Minor

Potential runtime error if agent.url is malformed.

new URL(agent.url).hostname will throw a TypeError if agent.url is empty, malformed, or not a valid URL, crashing the component.

🛡️ Proposed defensive fix

       {/* Footer */}
       <div className="px-3 py-2 bg-gradient-to-r from-muted/30 to-muted/20 border-t border-border">
         <p className="text-xs text-muted-foreground truncate flex items-center gap-1.5">
           <Globe className="w-3 h-3 flex-shrink-0" />
-          {new URL(agent.url).hostname}
+          {(() => {
+            try {
+              return new URL(agent.url).hostname;
+            } catch {
+              return agent.url;
+            }
+          })()}
         </p>
       </div>

Or extract to a helper function for cleaner code.

tenders-finder/src/components/tender/LiveBrowserModal.tsx-22-29 (1)

22-29: ⚠️ Potential issue | 🟡 Minor

Exit animations won't trigger due to early return.

The early return if (!isOpen) return null on line 22 bypasses AnimatePresence, so the exit animations defined on lines 29 and 36 will never run. The modal will disappear instantly instead of animating out.

Move the conditional inside AnimatePresence:

🐛 Proposed fix

-  if (!isOpen) return null;
-
   return (
     <AnimatePresence>
-      <motion.div
+      {isOpen && (
+        <motion.div
-        initial={{ opacity: 0 }}
-        animate={{ opacity: 1 }}
-        exit={{ opacity: 0 }}
+          initial={{ opacity: 0 }}
+          animate={{ opacity: 1 }}
+          exit={{ opacity: 0 }}
+          ...
+        </motion.div>
+      )}
     </AnimatePresence>
   );

tenders-finder/src/components/ui/navigation-menu.tsx (1)

47-47: Nitpick: Redundant "group" class.

The "group" class is already included in navigationMenuTriggerStyle (line 38), so adding it again here is unnecessary.

♻️ Suggested fix

-    className={cn(navigationMenuTriggerStyle(), "group", className)}
+    className={cn(navigationMenuTriggerStyle(), className)}

tenders-finder/src/components/ui/sheet.tsx (1)

40-41: Minor: Extra whitespace in class string.

There's a double space between w-3/4 and border-l.

🧹 Suggested fix

        right:
-          "inset-y-0 right-0 h-full w-3/4  border-l data-[state=closed]:slide-out-to-right data-[state=open]:slide-in-from-right sm:max-w-sm",
+          "inset-y-0 right-0 h-full w-3/4 border-l data-[state=closed]:slide-out-to-right data-[state=open]:slide-in-from-right sm:max-w-sm",

tenders-finder/src/components/ui/input-otp.tsx (1)

27-29: Consider adding defensive access for the slot context.

The destructuring of inputOTPContext.slots[index] assumes the context is always properly initialized and the index is within bounds. While this follows standard ShadCN patterns (assuming correct usage within the OTPInput hierarchy), adding a defensive check could prevent cryptic errors if misused.

🛡️ Optional defensive check

 >(({ index, className, ...props }, ref) => {
   const inputOTPContext = React.useContext(OTPInputContext);
-  const { char, hasFakeCaret, isActive } = inputOTPContext.slots[index];
+  const slot = inputOTPContext?.slots?.[index];
+  const { char, hasFakeCaret, isActive } = slot ?? {};

tenders-finder/src/components/ui/calendar.tsx (1)

10-51: Component implementation follows ShadCN UI patterns well.

The classNames structure correctly uses react-day-picker v8's snake_case naming convention, and spreading ...classNames at the end allows consumers to override defaults. The responsive layout with sm: breakpoints is appropriate.

One minor note on lines 45-46: the _props parameter is collected but unused. If the props from DayPicker aren't needed, this could be simplified.

♻️ Optional: Simplify unused props

       components={{
-        IconLeft: ({ ..._props }) => <ChevronLeft className="h-4 w-4" />,
-        IconRight: ({ ..._props }) => <ChevronRight className="h-4 w-4" />,
+        IconLeft: () => <ChevronLeft className="h-4 w-4" />,
+        IconRight: () => <ChevronRight className="h-4 w-4" />,
       }}

tenders-finder/src/components/ui/sidebar.tsx (1)

67-68: Consider adding SameSite attribute to cookie.

The cookie is set without an explicit SameSite attribute. While modern browsers default to Lax, being explicit improves clarity and ensures consistent behavior across all browsers.

♻️ Proposed fix

-      document.cookie = `${SIDEBAR_COOKIE_NAME}=${openState}; path=/; max-age=${SIDEBAR_COOKIE_MAX_AGE}`;
+      document.cookie = `${SIDEBAR_COOKIE_NAME}=${openState}; path=/; max-age=${SIDEBAR_COOKIE_MAX_AGE}; SameSite=Lax`;

tenders-finder/src/components/ui/progress.tsx (1)

15-18: Use max and clamp value to avoid overflow.

The indicator math is hard-coded to 100, so custom max props or out-of-range values will misrender. Consider clamping and scaling by max.

♻️ Proposed refactor

-const Progress = React.forwardRef<
+const Progress = React.forwardRef<
   React.ElementRef<typeof ProgressPrimitive.Root>,
   React.ComponentPropsWithoutRef<typeof ProgressPrimitive.Root>
->(({ className, value, ...props }, ref) => (
+>(({ className, value, max = 100, ...props }, ref) => (
   <ProgressPrimitive.Root
     ref={ref}
     className={cn("relative h-4 w-full overflow-hidden rounded-full bg-secondary", className)}
     {...props}
   >
     <ProgressPrimitive.Indicator
       className="h-full w-full flex-1 bg-primary transition-all"
-      style={{ transform: `translateX(-${100 - (value || 0)}%)` }}
+      style={{
+        transform: `translateX(-${
+          100 - ((Math.min(Math.max(value ?? 0, 0), max) / max) * 100)
+        }%)`,
+      }}
     />
   </ProgressPrimitive.Root>
 ));

tenders-finder/.gitignore (1)

1-24: Consider adding .env* patterns to prevent accidental secret commits.

Given that this project integrates with Supabase (per the PR summary), environment files containing API keys and secrets are likely in use. Adding patterns like .env, .env.local, .env*.local would provide defense-in-depth against accidental secret exposure.

Suggested addition

 node_modules
 dist
 dist-ssr
 *.local
+
+# Environment files
+.env
+.env.*
+!.env.example

tenders-finder/src/hooks/use-mobile.tsx (1)

8-16: Consider using mql.matches in the change handler for consistency.

The onChange handler recalculates using window.innerWidth instead of using mql.matches. While functionally equivalent, using mql.matches is more consistent with the media query approach and avoids potential edge-case discrepancies.

Suggested refinement

   React.useEffect(() => {
     const mql = window.matchMedia(`(max-width: ${MOBILE_BREAKPOINT - 1}px)`);
     const onChange = () => {
-      setIsMobile(window.innerWidth < MOBILE_BREAKPOINT);
+      setIsMobile(mql.matches);
     };
     mql.addEventListener("change", onChange);
-    setIsMobile(window.innerWidth < MOBILE_BREAKPOINT);
+    setIsMobile(mql.matches);
     return () => mql.removeEventListener("change", onChange);
   }, []);

tenders-finder/supabase/functions/discover-tender-links/index.ts (1)

20-32: Deduplicate the default links list to prevent drift.
The same list appears in three branches; centralizing it reduces maintenance risk.

♻️ Suggested refactor

 const corsHeaders = {
   "Access-Control-Allow-Origin": "*",
   "Access-Control-Allow-Headers": "authorization, x-client-info, apikey, content-type",
 };
+
+const DEFAULT_LINKS = [
+  { url: "https://www.gebiz.gov.sg/", name: "GeBIZ" },
+  { url: "https://www.tendersontime.com/singapore-tenders/", name: "Tenders On Time" },
+  { url: "https://www.biddetail.com/singapore-tenders", name: "Bid Detail" },
+  { url: "https://www.tendersinfo.com/global-singapore-tenders.php", name: "Tenders Info" },
+  { url: "https://www.globaltenders.com/government-tenders-singapore", name: "Global Tenders" },
+] as const;

-        JSON.stringify({
-          success: true,
-          links: [
-            { url: 'https://www.gebiz.gov.sg/', name: 'GeBIZ' },
-            { url: 'https://www.tendersontime.com/singapore-tenders/', name: 'Tenders On Time' },
-            { url: 'https://www.biddetail.com/singapore-tenders', name: 'Bid Detail' },
-            { url: 'https://www.tendersinfo.com/global-singapore-tenders.php', name: 'Tenders Info' },
-            { url: 'https://www.globaltenders.com/government-tenders-singapore', name: 'Global Tenders' },
-          ]
-        }),
+        JSON.stringify({ success: true, links: DEFAULT_LINKS }),

-      links = [
-        { url: 'https://www.gebiz.gov.sg/', name: 'GeBIZ' },
-        { url: 'https://www.tendersontime.com/singapore-tenders/', name: 'Tenders On Time' },
-        { url: 'https://www.biddetail.com/singapore-tenders', name: 'Bid Detail' },
-        { url: 'https://www.tendersinfo.com/global-singapore-tenders.php', name: 'Tenders Info' },
-        { url: 'https://www.globaltenders.com/government-tenders-singapore', name: 'Global Tenders' },
-      ];
+      links = [...DEFAULT_LINKS];

-        links: [
-          { url: 'https://www.gebiz.gov.sg/', name: 'GeBIZ' },
-          { url: 'https://www.tendersontime.com/singapore-tenders/', name: 'Tenders On Time' },
-          { url: 'https://www.biddetail.com/singapore-tenders', name: 'Bid Detail' },
-          { url: 'https://www.tendersinfo.com/global-singapore-tenders.php', name: 'Tenders Info' },
-          { url: 'https://www.globaltenders.com/government-tenders-singapore', name: 'Global Tenders' },
-        ]
+        links: DEFAULT_LINKS

Also applies to: 81-87, 102-108

tenders-finder/src/components/NavLink.tsx (1)

11-22: Support className callbacks for full NavLink parity.

React Router v6's NavLink accepts className as either a string or a callback function receiving { isActive, isPending } and returning a string. The current wrapper restricts className to string only, preventing consumers from using the callback form.

To support the full NavLink API, update the interface to accept NavLinkProps["className"] and handle both string and function forms:

Proposed implementation

-interface NavLinkCompatProps extends Omit<NavLinkProps, "className"> {
-  className?: string;
+interface NavLinkCompatProps extends Omit<NavLinkProps, "className"> {
+  className?: NavLinkProps["className"];
   activeClassName?: string;
   pendingClassName?: string;
 }
@@
-        className={({ isActive, isPending }) =>
-          cn(className, isActive && activeClassName, isPending && pendingClassName)
-        }
+        className={({ isActive, isPending }) => {
+          const baseClassName =
+            typeof className === "function" ? className({ isActive, isPending }) : className;
+          return cn(baseClassName, isActive && activeClassName, isPending && pendingClassName);
+        }}

tenders-finder/supabase/functions/mino-tender-search/index.ts (2)

102-175: Consider explicit reader cleanup on errors.

If an error occurs during stream processing, the reader should be explicitly released to avoid resource leaks in long-running scenarios.

Suggested pattern

           if (reader) {
+            try {
               while (true) {
                 const { done, value } = await reader.read();
                 if (done) break;
                 // ... processing ...
               }
+            } finally {
+              reader.releaseLock();
+            }
           }

---

1-4: Wildcard CORS origin for production consideration.

Using 'Access-Control-Allow-Origin': '*' is acceptable for development but should be restricted to specific origins in production deployments.

tenders-finder/src/components/tender/CompareModal.tsx (1)

32-44: Consider adding keyboard accessibility.

The modal lacks keyboard escape handling and focus management. Users should be able to close the modal with the Escape key, and focus should be trapped within the modal while open.

Suggested addition

// Add useEffect for escape key handling
React.useEffect(() => {
  const handleEscape = (e: KeyboardEvent) => {
    if (e.key === 'Escape') onClose();
  };
  if (isOpen) {
    document.addEventListener('keydown', handleEscape);
    return () => document.removeEventListener('keydown', handleEscape);
  }
}, [isOpen, onClose]);

Consider using a Dialog primitive from Radix UI for built-in accessibility features.

tenders-finder/src/hooks/useTenderSearch.ts (1)

42-55: Fail fast when Supabase env vars are missing

If the env vars are absent, the fetch URL becomes invalid and errors are opaque. A guard gives a clearer failure mode.

🛠️ Suggested guard

 const startSearch = useCallback(async (sector: Sector, links: string[]) => {
+    if (!SUPABASE_URL || !SUPABASE_ANON_KEY) {
+      const erroredAgents = createAgentsFromLinks(links).map(agent => ({
+        ...agent,
+        status: 'error' as const,
+        message: 'Missing Supabase configuration',
+      }));
+      setState(prev => ({
+        ...prev,
+        isSearching: false,
+        selectedSector: sector,
+        agents: erroredAgents,
+        tenders: [],
+        selectedTenders: new Set(),
+      }));
+      return;
+    }
     // Initialize agents from provided links

tenders-finder/tsconfig.json (1)

2-8: Root config's compiler options are not inherited; consolidate using extends to avoid duplication.

Neither tsconfig.app.json nor tsconfig.node.json extends this root config. As a result, the baseUrl and paths options defined here are unused. tsconfig.app.json redefines them directly, while tsconfig.node.json doesn't need them. To eliminate duplication and leverage shared configuration, have tsconfig.app.json extend this root config and remove the redundant baseUrl/paths definitions.

tenders-finder/src/pages/NotFound.tsx (1)

1-18: Prefer <Link> for client-side navigation.

Line 16-18 uses a plain anchor, which forces a full page reload and bypasses SPA routing. Using <Link> preserves client-side navigation and app state.

🔁 Suggested change

-import { useLocation } from "react-router-dom";
+import { Link, useLocation } from "react-router-dom";
@@
-        <a href="/" className="text-primary underline hover:text-primary/90">
+        <Link to="/" className="text-primary underline hover:text-primary/90">
           Return to Home
-        </a>
+        </Link>

tenders-finder/package.json (1)

2-2: Project name doesn't match directory name.

The package name vite_react_shadcn_ts appears to be a template placeholder. Consider renaming it to tenders-finder to match the project directory and improve clarity.

-  "name": "vite_react_shadcn_ts",
+  "name": "tenders-finder",

tenders-finder/src/components/tender/TenderResultCard.tsx (1)

15-27: Consider adding keyboard accessibility for the clickable card.

The card is clickable via onClick but lacks keyboard support. Users navigating with keyboards won't be able to select tenders. Consider adding role="button", tabIndex={0}, and an onKeyDown handler.

     <motion.div
       initial={{ opacity: 0, y: 20 }}
       animate={{ opacity: 1, y: 0 }}
       whileHover={{ scale: 1.01 }}
       onClick={onToggleSelect}
+      onKeyDown={(e) => { if (e.key === 'Enter' || e.key === ' ') { e.preventDefault(); onToggleSelect(); }}}
+      role="button"
+      tabIndex={0}
       className={cn(

tenders-finder/tsconfig.app.json (1)

18-23: TypeScript strict checks are disabled, reducing type safety.

All linting options are turned off, which significantly reduces TypeScript's ability to catch bugs at compile time:

• strict: false disables all strict type-checking
• noImplicitAny: false allows untyped variables
• noFallthroughCasesInSwitch: false can lead to accidental switch fallthrough bugs

For a new project, consider enabling at least strict: true to catch issues early. You can incrementally enable other options later.

     /* Linting */
-    "strict": false,
-    "noUnusedLocals": false,
-    "noUnusedParameters": false,
-    "noImplicitAny": false,
-    "noFallthroughCasesInSwitch": false,
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noFallthroughCasesInSwitch": true,

tenders-finder/src/App.css (1)

1-42: This appears to be Vite template boilerplate CSS.

This file contains default Vite template styles (logo animations, .read-the-docs class) that don't seem relevant to a Tenders Finder application. Since the project uses Tailwind CSS for styling, consider removing this file or cleaning it up to only include styles actually used by the app.

tenders-finder/src/components/ui/accordion.tsx (1)

41-47: Apply className to the Content wrapper (not just the inner div).
This aligns with expected API behavior for styling the Radix content element.

♻️ Suggested adjustment

   <AccordionPrimitive.Content
     ref={ref}
-    className="overflow-hidden text-sm transition-all data-[state=closed]:animate-accordion-up data-[state=open]:animate-accordion-down"
+    className={cn(
+      "overflow-hidden text-sm transition-all data-[state=closed]:animate-accordion-up data-[state=open]:animate-accordion-down",
+      className
+    )}
     {...props}
   >
-    <div className={cn("pb-4 pt-0", className)}>{children}</div>
+    <div className="pb-4 pt-0">{children}</div>
   </AccordionPrimitive.Content>

tenders-finder/src/components/tender/TenderResultsList.tsx (1)

59-74: Consider capping staggered animation delay for large result sets.

The staggered delay index * 0.05 will cause the last items to appear very late if the result set is large (e.g., 100 tenders = 5 seconds delay for the last card). Consider capping the delay:

♻️ Suggested improvement

             <motion.div
               key={tender.id}
               initial={{ opacity: 0, y: 20 }}
               animate={{ opacity: 1, y: 0 }}
-              transition={{ delay: index * 0.05 }}
+              transition={{ delay: Math.min(index * 0.05, 0.5) }}
             >

tenders-finder/src/pages/Index.tsx (1)

127-133: CompareButton may show inappropriately in non-search views.

The CompareButton is rendered whenever tenders.length > 0, but this condition doesn't account for the current view state. If tenders exist from a previous search, the button will appear even in the selector or config views until resetSearch() is called.

Consider adding a view check:

♻️ Suggested fix

       {/* Compare Button - only show when we have results */}
-      {tenders.length > 0 && (
+      {view === 'search' && tenders.length > 0 && (
         <CompareButton
           selectedCount={selectedTenders.size}
           onCompare={handleCompare}
         />
       )}

tenders-finder/src/components/tender/LinkConfigPage.tsx (2)

56-65: Extract duplicated fallback URLs to a constant.

The same fallback URLs are repeated three times (lines 58-64, 83-89, 104-110). This violates DRY and increases maintenance burden if the fallback list needs updating.

♻️ Proposed refactor

+const FALLBACK_TENDER_LINKS = [
+  'https://www.gebiz.gov.sg/',
+  'https://www.tendersontime.com/singapore-tenders/',
+  'https://www.biddetail.com/singapore-tenders',
+  'https://www.tendersinfo.com/global-singapore-tenders.php',
+  'https://www.globaltenders.com/government-tenders-singapore',
+];
+
 export function LinkConfigPage({ sector, onBack, onStartSearch }: LinkConfigPageProps) {
   // ...
   
   const fetchAILinks = async (count: number = 5): Promise<string[]> => {
     try {
       // ...
     } catch (error) {
       console.error('Error fetching AI links:', error);
-      return [
-        'https://www.gebiz.gov.sg/',
-        // ... repeated URLs
-      ];
+      return FALLBACK_TENDER_LINKS;
     }
   };

Then use FALLBACK_TENDER_LINKS in all three locations.

Also applies to: 83-91, 104-111

---

52-54: Consider adding type safety for API response.

The any type cast on line 53 bypasses TypeScript's type checking. Consider defining an interface for the expected response shape.

♻️ Suggested improvement

+interface DiscoverLinksResponse {
+  links: Array<{ url: string }>;
+}
+
 const fetchAILinks = async (count: number = 5): Promise<string[]> => {
   try {
-    const { data, error } = await supabase.functions.invoke('discover-tender-links', {
+    const { data, error } = await supabase.functions.invoke<DiscoverLinksResponse>('discover-tender-links', {
       body: { sector, limit: count }
     });
     
     if (error) throw error;
     
     if (data?.links) {
-      return data.links.map((link: any) => link.url);
+      return data.links.map((link) => link.url);
     }

tutors-finder/src/components/ui/carousel.tsx-96-102 (1)

96-102: ⚠️ Potential issue | 🟡 Minor

Remove the reInit listener in cleanup.

The reInit listener is registered (line 97) but not removed in the cleanup function. Embla Carousel listeners persist across reInit events, so without explicit cleanup, duplicate handlers accumulate when the effect re-runs—which occurs whenever api or onSelect changes.

Suggested fix

      return () => {
        api?.off("select", onSelect);
+       api?.off("reInit", onSelect);
      };

tutors-finder/src/components/ui/input-otp.tsx-52-57 (1)

52-57: ⚠️ Potential issue | 🟡 Minor

Hide the decorative dot icon from assistive tech.
The separator dot is decorative and should be removed from the accessibility tree. Although lucide-react icons have aria-hidden="true" by default, explicitly marking it as inert is a best practice for clarity and compatibility.

♿ Suggested accessibility tweak

-  ({ ...props }, ref) => (
-    <div ref={ref} role="separator" {...props}>
-      <Dot />
+  ({ ...props }, ref) => (
+    <div ref={ref} role="separator" {...props}>
+      <Dot aria-hidden="true" focusable="false" />
     </div>
   ),

tutors-finder/src/components/ui/input-otp.tsx-24-48 (1)

24-48: ⚠️ Potential issue | 🟡 Minor

Add defensive guard for context and slot access to prevent runtime crashes.

Line 29 directly destructures from inputOTPContext.slots[index] without checking if the context or slot exists. If this component is used outside an InputOTP provider or with an invalid index, it will throw. The input-otp v1.4.x library does not guarantee that slots[index] is always present.

Suggested fix

  const inputOTPContext = React.useContext(OTPInputContext);
+  const slot = inputOTPContext?.slots?.[index];
+  if (!slot) {
+    return null;
+  }
-  const { char, hasFakeCaret, isActive } = inputOTPContext.slots[index];
+  const { char, hasFakeCaret, isActive } = slot;

tutors-finder/src/components/ui/chart.tsx-92-226 (1)

92-226: ⚠️ Potential issue | 🟡 Minor

Don’t hide zero values in tooltip; tighten key stability.

item.value && ... drops legitimate 0 values. Also key={item.dataKey} can be undefined, leading to unstable keys.

✅ Suggested fix

-          {payload.map((item, index) => {
+          {payload.map((item, index) => {
             const key = `${nameKey || item.name || item.dataKey || "value"}`;
             const itemConfig = getPayloadConfigFromPayload(config, item, key);
             const indicatorColor = color || item.payload.fill || item.color;
+            const itemKey = `${item.dataKey ?? item.name ?? index}`;
 
             return (
               <div
-                key={item.dataKey}
+                key={itemKey}
                 className={cn(
                   "flex w-full flex-wrap items-stretch gap-2 [&>svg]:h-2.5 [&>svg]:w-2.5 [&>svg]:text-muted-foreground",
                   indicator === "dot" && "items-center",
                 )}
               >
@@
-                      {item.value && (
+                      {item.value !== undefined && item.value !== null && (
                         <span className="font-mono font-medium tabular-nums text-foreground">
                           {item.value.toLocaleString()}
                         </span>
                       )}

tutors-finder/src/components/ExamSelector.tsx-38-40 (1)

38-40: ⚠️ Potential issue | 🟡 Minor

Add type="button" to prevent accidental form submission.
When rendered inside a form, the default type is submit.

🔧 Proposed fix

-          <button
+          <button type="button"
             key={type}
             onClick={() => onSelect(type)}

tutors-finder/src/components/CompareDashboard.tsx-59-61 (1)

59-61: ⚠️ Potential issue | 🟡 Minor

Add accessible label to close button.

The icon-only button lacks an accessible label for screen reader users. Consider adding aria-label or using sr-only text.

♿ Proposed fix for accessibility

-          <Button variant="ghost" size="icon" onClick={onClose}>
+          <Button variant="ghost" size="icon" onClick={onClose} aria-label="Close comparison">
             <X className="w-6 h-6" />
           </Button>

tutors-finder/src/hooks/use-toast.ts-6-6 (1)

6-6: ⚠️ Potential issue | 🟡 Minor

TOAST_REMOVE_DELAY of ~16.7 minutes seems excessively long.

TOAST_REMOVE_DELAY = 1000000 (1,000,000ms ≈ 16.7 minutes) means dismissed toasts remain in state for a very long time before being removed. This is likely unintentional. Typical values are 3-5 seconds.

🐛 Proposed fix

 const TOAST_LIMIT = 1;
-const TOAST_REMOVE_DELAY = 1000000;
+const TOAST_REMOVE_DELAY = 5000; // 5 seconds

tutors-finder/supabase/functions/discover-tutor-websites/index.ts-94-114 (1)

94-114: ⚠️ Potential issue | 🟡 Minor

Fallback only triggers on JSON parse errors, not on empty/invalid AI responses.

The fallback logic at lines 105-113 only executes when JSON.parse throws. If the AI returns valid JSON that doesn't match the expected schema (e.g., an empty array, or objects missing name/url fields), websites will be set to that invalid data without validation.

🛡️ Proposed fix to validate parsed websites

     let websites: { name: string; url: string }[] = [];
     try {
       // Try to extract JSON array from the response
       const jsonMatch = content.match(/\[[\s\S]*\]/);
       if (jsonMatch) {
-        websites = JSON.parse(jsonMatch[0]);
+        const parsed = JSON.parse(jsonMatch[0]);
+        // Validate that parsed data is an array with valid entries
+        if (Array.isArray(parsed) && parsed.length > 0 && 
+            parsed.every(w => typeof w.name === 'string' && typeof w.url === 'string')) {
+          websites = parsed;
+        } else {
+          throw new Error('Invalid website data structure');
+        }
       }
     } catch (parseError) {

tutors-finder/src/components/ui/breadcrumb.tsx-69-80 (1)

69-80: ⚠️ Potential issue | 🟡 Minor

Fix BreadcrumbEllipsis displayName typo.

This affects debug tooling and devtools readability.

🛠️ Proposed fix

-BreadcrumbEllipsis.displayName = "BreadcrumbElipssis";
+BreadcrumbEllipsis.displayName = "BreadcrumbEllipsis";

tutors-finder/src/components/ui/breadcrumb.tsx-7-13 (1)

7-13: ⚠️ Potential issue | 🟡 Minor

separator prop is unused in Breadcrumb.

Either wire this prop through a context/child API or remove it to avoid a misleading public surface.

🛠️ Proposed fix (remove unused prop)

 const Breadcrumb = React.forwardRef<
   HTMLElement,
-  React.ComponentPropsWithoutRef<"nav"> & {
-    separator?: React.ReactNode;
-  }
+  React.ComponentPropsWithoutRef<"nav">
 >(({ ...props }, ref) => <nav ref={ref} aria-label="breadcrumb" {...props} />);

tutors-finder/src/components/ui/card.tsx-17-22 (1)

17-22: ⚠️ Potential issue | 🟡 Minor

Align CardTitle ref type with the rendered heading element.

The component renders an <h3> but the ref is typed as HTMLParagraphElement. Change the ref type to HTMLHeadingElement to match the actual DOM element.

🛠️ Proposed fix

-const CardTitle = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLHeadingElement>>(
+const CardTitle = React.forwardRef<HTMLHeadingElement, React.HTMLAttributes<HTMLHeadingElement>>(
   ({ className, ...props }, ref) => (
     <h3 ref={ref} className={cn("text-2xl font-semibold leading-none tracking-tight", className)} {...props} />
   ),
 );

tutors-finder/src/components/ui/alert.tsx-36-43 (1)

36-43: ⚠️ Potential issue | 🟡 Minor

Fix AlertDescription ref and props types to match the rendered <div>.

The component renders a <div> but is typed as HTMLParagraphElement for both the ref and props.

🛠️ Proposed fix

-const AlertDescription = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLParagraphElement>>(
+const AlertDescription = React.forwardRef<HTMLDivElement, React.HTMLAttributes<HTMLDivElement>>(
   ({ className, ...props }, ref) => (
     <div ref={ref} className={cn("text-sm [&_p]:leading-relaxed", className)} {...props} />
   ),
 );

tutors-finder/src/components/ui/alert.tsx-29-34 (1)

29-34: ⚠️ Potential issue | 🟡 Minor

Fix AlertTitle ref type to match <h5>.

The ref is typed as HTMLParagraphElement but the component renders an <h5>, which should use HTMLHeadingElement.

Proposed fix

-const AlertTitle = React.forwardRef<HTMLParagraphElement, React.HTMLAttributes<HTMLHeadingElement>>(
+const AlertTitle = React.forwardRef<HTMLHeadingElement, React.HTMLAttributes<HTMLHeadingElement>>(
   ({ className, ...props }, ref) => (
     <h5 ref={ref} className={cn("mb-1 font-medium leading-none tracking-tight", className)} {...props} />
   ),
 );

tutors-finder/src/components/ui/form.tsx-33-54 (1)

33-54: ⚠️ Potential issue | 🟡 Minor

Guard useFormField before calling getFieldState.

The current if (!fieldContext) check is ineffective—context defaults to {} (truthy). Additionally, getFieldState is invoked with fieldContext.name (line 38) before validating it exists, and itemContext.id is destructured (line 44) without null checks. Validate both fieldContext.name and itemContext.id before calling getFieldState.

🛠️ Proposed fix

 const useFormField = () => {
   const fieldContext = React.useContext(FormFieldContext);
   const itemContext = React.useContext(FormItemContext);
   const { getFieldState, formState } = useFormContext();
-
-  const fieldState = getFieldState(fieldContext.name, formState);
-
-  if (!fieldContext) {
+  if (!fieldContext?.name) {
     throw new Error("useFormField should be used within <FormField>");
   }
+  if (!itemContext?.id) {
+    throw new Error("useFormField should be used within <FormItem>");
+  }
+
+  const fieldState = getFieldState(fieldContext.name, formState);
 
   const { id } = itemContext;

tutors-finder/src/hooks/useTutorSearch.ts-45-53 (1)

45-53: ⚠️ Potential issue | 🟡 Minor

Keep state.exam in sync when starting a search

startSearch resets state but doesn’t persist the exam argument, so state.exam can stay stale if callers don’t invoke setExam first.

🛠️ Proposed fix

-    setState((prev) => ({
-      ...prev,
-      location,
+    setState((prev) => ({
+      ...prev,
+      exam,
+      location,
       isSearching: true,
       isDiscovering: true,
       agents: [],
       tutors: [],
       selectedTutorIds: new Set(),
     }));

tutors-finder/src/components/ui/menubar.tsx-188-188 (1)

188-188: ⚠️ Potential issue | 🟡 Minor

Fix typo: displayname should be displayName.

The property name is misspelled with a lowercase n. This will result in the display name not being properly set for React DevTools and error messages.

🐛 Proposed fix

-MenubarShortcut.displayname = "MenubarShortcut";
+MenubarShortcut.displayName = "MenubarShortcut";

tutors-finder/src/components/ui/sidebar.tsx-54-69 (1)

54-69: ⚠️ Potential issue | 🟡 Minor

Persisted state is written but never read.
The cookie is set on toggle but never used to initialize state, so the sidebar won’t restore after refresh. Consider hydrating _open from the cookie.

🧩 Proposed fix

-  const [_open, _setOpen] = React.useState(defaultOpen);
+  const [_open, _setOpen] = React.useState(() => {
+    if (typeof document === "undefined") return defaultOpen;
+    const cookie = document.cookie
+      .split("; ")
+      .find((row) => row.startsWith(`${SIDEBAR_COOKIE_NAME}=`))
+      ?.split("=")[1];
+    if (cookie === "true") return true;
+    if (cookie === "false") return false;
+    return defaultOpen;
+  });

tutors-finder/src/pages/Index.tsx-19-43 (1)

19-43: ⚠️ Potential issue | 🟡 Minor

Reset compare state when starting or resetting a search.

showCompare stays true after a reset, so a new search can auto-open the compare dashboard once two tutors are selected. Clear it when starting or resetting the search.

🛠️ Suggested fix

-  const handleSearch = (location: string) => {
-    if (state.exam) {
-      startSearch(state.exam, location);
-    }
-  };
+  const handleSearch = (location: string) => {
+    if (state.exam) {
+      setShowCompare(false);
+      startSearch(state.exam, location);
+    }
+  };
+
+  const handleReset = () => {
+    setShowCompare(false);
+    resetSearch();
+  };
@@
-            <Button variant="ghost" size="sm" onClick={resetSearch} className="gap-2">
+            <Button variant="ghost" size="sm" onClick={handleReset} className="gap-2">

tutors-finder/README.md-42-113 (1)

42-113: ⚠️ Potential issue | 🟡 Minor

Align README terminology and code fence with the Tutor Finder stack.

The snippet is JavaScript but fenced as bash, and the tech stack/diagram still reference “Next.js” and “Tender” terminology. Please update to reflect the Tutors Finder Vite/React app and tutor-centric architecture.

✏️ Suggested doc fixes

-```bash
+```ts
@@
-**Next.js (TypeScript)**
+**Vite + React + TypeScript**
@@
-ORCH["Tender Search Orchestration Layer<br/>(Next.js API / Server Actions)"]
+ORCH["Tutor Search Orchestration Layer<br/>(Serverless API / Functions)"]
@@
-DB["SUPABASE<br/>(Cached Tenders & Metadata)"]
+DB["SUPABASE<br/>(Cached Tutors & Metadata)"]
@@
-DBD["• Cached tender listings<br/>• Deduplicated tenders<br/>• Historical records"]
-MINOD["• Parallel web agents<br/>• Browse govt tender portals<br/>• Open tender pages<br/>• Extract structured fields<br/>• SSE streaming updates"]
+DBD["• Cached tutor listings<br/>• Deduplicated tutors<br/>• Historical records"]
+MINOD["• Parallel web agents<br/>• Browse tutor platforms<br/>• Open tutor pages<br/>• Extract structured fields<br/>• SSE streaming updates"]

tutors-finder/src/components/CompareButton.tsx (2)

29-31: Minor: Button text has trailing space when no items selected.

When selectedCount is 0, the button renders "Compare " with a trailing space before the empty string. Consider trimming or restructuring:

✨ Suggested fix

-        Compare {selectedCount > 0 ? `(${selectedCount} selected)` : ''}
+        Compare{selectedCount > 0 ? ` (${selectedCount} selected)` : ''}

---

23-34: Consider hiding the button when nothing is selected.

The compare button is always visible even when selectedCount is 0. While this aids discoverability, it may add visual clutter. Consider conditionally rendering or disabling the button when there are no selections.

✨ Option: Conditionally render the button

+  if (selectedCount === 0) {
+    return null;
+  }
+
   return (
     <div className="fixed bottom-6 left-1/2 -translate-x-1/2 z-40">

tutors-finder/src/hooks/use-mobile.tsx (1)

9-14: Consider using event.matches for consistency with the MediaQueryList.

The onChange handler ignores the MediaQueryListEvent and re-queries window.innerWidth. Using event.matches is more idiomatic and avoids the redundant width check.

♻️ Suggested refactor

   React.useEffect(() => {
     const mql = window.matchMedia(`(max-width: ${MOBILE_BREAKPOINT - 1}px)`);
-    const onChange = () => {
-      setIsMobile(window.innerWidth < MOBILE_BREAKPOINT);
-    };
+    const onChange = (event: MediaQueryListEvent) => {
+      setIsMobile(event.matches);
+    };
     mql.addEventListener("change", onChange);
-    setIsMobile(window.innerWidth < MOBILE_BREAKPOINT);
+    setIsMobile(mql.matches);
     return () => mql.removeEventListener("change", onChange);
   }, []);

tutors-finder/src/components/ui/progress.tsx (1)

16-17: Clamp value to [0, 100] to avoid over/under-fill.

If value goes below 0 or above 100, the bar can render outside bounds. A small clamp improves robustness without affecting typical use.

♻️ Suggested tweak

-    <ProgressPrimitive.Indicator
+    <ProgressPrimitive.Indicator
       className="h-full w-full flex-1 bg-primary transition-all"
-      style={{ transform: `translateX(-${100 - (value || 0)}%)` }}
+      style={{
+        transform: `translateX(-${100 - Math.min(100, Math.max(0, value ?? 0))}%)`,
+      }}
     />

tutors-finder/src/components/ui/chart.tsx (1)

230-275: Legend keys/labels should be stable and non-empty.

key={item.value} can collide and labels can render empty if config omits label. Consider a stable key fallback and a label fallback to item.value or item.name.

♻️ Suggested refinement

-      {payload.map((item) => {
+      {payload.map((item) => {
         const key = `${nameKey || item.dataKey || "value"}`;
         const itemConfig = getPayloadConfigFromPayload(config, item, key);
+        const itemKey = `${item.dataKey ?? item.value ?? item.name ?? ""}`;

         return (
           <div
-            key={item.value}
+            key={itemKey}
             className={cn("flex items-center gap-1.5 [&>svg]:h-3 [&>svg]:w-3 [&>svg]:text-muted-foreground")}
           >
@@
-            {itemConfig?.label}
+            {itemConfig?.label ?? item.value ?? item.name}
           </div>
         );
       })}

tutors-finder/src/components/ui/toggle-group.tsx (1)

34-37: Variant/size priority may be inverted.

The current logic context.variant || variant gives context priority over item-level props. This means if ToggleGroup sets a variant, individual ToggleGroupItem cannot override it. Typically, item-level props should take precedence to allow per-item customization.

💡 Proposed fix to prioritize item-level props

         toggleVariants({
-          variant: context.variant || variant,
-          size: context.size || size,
+          variant: variant || context.variant,
+          size: size || context.size,
         }),

tutors-finder/supabase/functions/discover-tutor-websites/index.ts (1)

92-92: Avoid logging full AI response content in production.

Logging the entire AI response at line 92 could expose sensitive or verbose data in production logs. Consider logging only essential metadata or using a debug flag.

♻️ Suggested change

-    console.log('AI response:', content);
+    console.log('AI response received, length:', content.length);

tutors-finder/src/components/TutorResultsGrid.tsx (1)

57-85: Consider extracting placeholder card to a separate component.

The placeholder card markup (lines 61-82) is fairly verbose. If similar placeholders are used elsewhere or this component grows, extracting it to a TutorCardPlaceholder component would improve maintainability.

tutors-finder/src/components/ui/command.tsx (1)

24-24: Consider simplifying the empty interface extension.

The CommandDialogProps interface extends DialogProps without adding any properties. You could use a type alias instead for clarity.

♻️ Suggested simplification

-interface CommandDialogProps extends DialogProps {}
+type CommandDialogProps = DialogProps;

tutors-finder/src/pages/NotFound.tsx (1)

1-18: Use Link for internal SPA navigation instead of an anchor tag.

React Router's Link handles client-side routing and avoids full page reloads, while <a href> triggers a hard refresh. Since "/" is an internal route, using Link follows React Router best practices.

Suggested refactor

-import { useLocation } from "react-router-dom";
+import { Link, useLocation } from "react-router-dom";
@@
-        <a href="/" className="text-primary underline hover:text-primary/90">
+        <Link to="/" className="text-primary underline hover:text-primary/90">
           Return to Home
-        </a>
+        </Link>